Add initial bucket creation capabilities and related tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falquaddoomi
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
This all looks good and seems to work: I see that the bucket and service account are created, with the appropriate permissions assigned to the new account. I have questions about how and by whom this will be used, but we can talk over that in person, perhaps. This is definitely a good start!
|
Thank you @falquaddoomi ! Happy to chat more about this. |
d33bs
added a commit
to d33bs/gc-cloud-storage-bucket
that referenced
this pull request
Sep 19, 2023
…BMI#2) * changes for assayworks project specifics * update shell script with bucket name * detemplatize; gsutil instructions * assay works docs context; simplify source dir * bucket.get svc-acct role binding * move gsutil work from .sh to .bat file Co-Authored-By: Faisal Alquaddoomi <[email protected]> * linting; remove shellcheck * rename gsutil file, remove .sh file * remove shellcheck Co-authored-by: Faisal Alquaddoomi <[email protected]>
d33bs
added a commit
that referenced
this pull request
Sep 19, 2023
* Initial commit * Add gsutil script and Assay.Works specifics (#1) * changes for assayworks project specifics * update shell script with bucket name * detemplatize; gsutil instructions * assay works docs context; simplify source dir * Move to .bat file and add Terraform role for bucket permissions (#2) * changes for assayworks project specifics * update shell script with bucket name * detemplatize; gsutil instructions * assay works docs context; simplify source dir * bucket.get svc-acct role binding * move gsutil work from .sh to .bat file Co-Authored-By: Faisal Alquaddoomi <[email protected]> * linting; remove shellcheck * rename gsutil file, remove .sh file * remove shellcheck Co-authored-by: Faisal Alquaddoomi <[email protected]> * Add multi-threading option for gsutil command (#3) * add multi-threaded option for gsutil * add docs for gsutil options * Adds documentation for Way Lab rclone usage (#4) * add way lab docs; reorganize utilities dir also add new repo diagram to increase role-based context understanding * linting change * Add Terraform state management resources and documentation (#5) * update existing tf to new location * add prep dir with state mgmt bucket * add hashicorp dir ignores * versions and lock file * rename to state-management dir * additional tf ignore * add state management instructions * state management bucket naming * single tf bucket var name * update lockfile * pre-commit image source image pin * tf backend comment * simplify state mgmt language Co-Authored-By: Faisal Alquaddoomi <[email protected]> * use specific version of dagger gh-action --------- Co-authored-by: Faisal Alquaddoomi <[email protected]> * Merge updates from 'gc-durbinlab-bucket/main' * rename and move files for template * update pre-commit deps * docs lint * ignore root terraform dir for pre-commit md lint * remove locks * data provider and receiver docs updates * poetry project updates * tf image updaet * image linting docs update * update readme for accurate role descriptions * generic bucket name replacements * update terraform provider versions + docs * Apply suggestions from code review Co-authored-by: Faisal Alquaddoomi <[email protected]> * add note about service account credential location * ignore the tf created svc account credential file --------- Co-authored-by: Faisal Alquaddoomi <[email protected]> Co-authored-by: Faisal Alquaddoomi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes initial work to enable Terraform Google Cloud bucket creation capabilities for this template repository.
Note: some of my intent was to containerize the deployment capabilities within Dagger but this might have impacted the development timeline and added more complexity to the work found here. I've spurred #1 into place to explore this work in the future.
Thanks in advance for any suggestions or comments you may have!