Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dracula style theme based on kaleidochromic and a new progress bar type #25

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

bradmartti
Copy link
Contributor

No description provided.

@CTalvio
Copy link
Owner

CTalvio commented Jan 18, 2022

Took it for a spin, not to my type of look but customization is the name of the game, so all additions are welcome!

Some changes I want to see. Generally the presets are just a collection of imports and a few extra lines of code on top. It looks like you've copied the code from the relevant modules in one after another. But please look at the existing presets and copy their structure. Any code that is not unique to the preset should be imported rather than copied, as this way any updates and fixes made to that code will apply to the preset without any need to maintain the preset in parallel.

I also spotted some bugs, assuming I applied the code correctly... Seeing some blue accents when selecting text fields, and there is a size difference between watched and unwatched indicators for some reason.

Thank you for your work, once the structure matches the rest of Ultrachromic, I'll be happy to merge!

@CTalvio CTalvio self-requested a review January 18, 2022 22:03
Copy link
Owner

@CTalvio CTalvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace any pre-existing code with imports, move topbarprogress.css into /progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants