-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kern.features.cheri_purecap_kernel #2229
base: dev
Are you sure you want to change the base?
Conversation
Nothing in tree uses the old feature flag so I think it's safe to drop. Could keep it for a release instead, but we'd then need to remember to remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth renaming other features to match kernel config options and indicate that they refer to CHERI/Morello:
kern.features.subobject_bounds
tokern.features.cheri_subobject_bounds
kern.features.cheri_revoke
tokern.features.cheri_caprevoke
kern.features.benchmark_abi_kernel
tokern.features.morello_benchmarkabi_kernel
.
That would be useful when listing features with sysctl kern.features | grep 'cheri\|morello'
.
This doesn't say purecap in it. Given we have cheri_purecap_kernel, probably morello_purecap_benchmark_kernel is the best thing (with a possible _abi in there too if you want). |
This one is queried by bits of userspace, so an upgraded kernel would break them. |
This should say kernel in it too for the feature name? |
Rename misleading kern.features.cheriabi_kernel to kern.features.cheri_purecap_kernel and make clear that it's a pure-capaiblity kernel (not CheriABI which refers to userspace).
subobject_bounds -> cheri_subobject_bounds_kernel benchmark_abi_kernel -> morello_purecap_benchmark_abi_kernel Make it clear that these are kernel things and that subobject bounds is realted to CHERI.
21c47d0
to
0203c36
Compare
This would be mostly harmless and transient if we fixed userspace. It's used to suppress some warnings in libprocstat when the feature is missing and as well as skip some cheribsdtest tests so there would be a modest incompatibility between mismatched kernel and userspace but not critical breakage. |
Rename misleading kern.features.cheriabi_kernel to kern.features.cheri_purecap_kernel and make clear that it's a pure-capaiblity kernel (not CheriABI which refers to userspace).