Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse set() options correctly #157

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AutonomicPerfectionist
Copy link
Contributor

Is this pull request associated with an issue(s)?
Fixes #155

Description
This PR completely redesigns the set() command processor. It parses the parameters to the call according to https://cmake.org/cmake/help/latest/command/set.html. Notes are generated for certain options like PARENT_SCOPE or CACHE.

TODOs

  • Generate notes for parsed options
  • Add tests for many different variations of set()
  • Probably refactor the option() processor

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5155867) 97.17% compared to head (30d38aa) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   97.17%   97.27%   +0.09%     
==========================================
  Files           8        8              
  Lines         992     1028      +36     
==========================================
+ Hits          964     1000      +36     
  Misses         28       28              
Flag Coverage Δ
unittests 97.27% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Documenting a set() command with PARENT_SCOPE (or other flags) generates incorrect documentation
2 participants