Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering on search query for search bar component #29

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

philliparaujo
Copy link

I previously added a visual search bar component that had almost no functionality. This PR hooks up the front-end component to a function that gets all topics within the category, and only keeps the topics that match the given search query.

When the search function runs, some of the meta-data about the topics are rendered incorrectly, but I can't figure out why. All the topics are still clickable and usable, so I think it's good enough, especially for a proof-of-concept.

Next steps: add automated testing showing that search queries work.

@philliparaujo philliparaujo added this to the Sprint 2 milestone Oct 8, 2024
@philliparaujo philliparaujo requested a review from heyanuja October 8, 2024 18:51
@philliparaujo philliparaujo marked this pull request as ready for review October 8, 2024 18:56
Copy link

@heyanuja heyanuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Bar logic and query filtering looks right. Going to approve and pull into new branch to test. Might revisit meta-data rendering issue

@heyanuja heyanuja merged commit a205c22 into f24 Oct 9, 2024
1 check passed
@philliparaujo philliparaujo deleted the search-combine branch October 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants