Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported tpl files from the commit linked in Slack by Prof. Hilton and added names to the README #16

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

bencondemi
Copy link

@bencondemi bencondemi commented Sep 20, 2024

I imported the tpl files from the commit linked in Slack by Prof. Hilton so that we can hopefully begin to be better able to edit the frontend of NodeBB. I followed the instructions posted in the Slack channel by the professor.

Also added team member names to the README. Resolves #1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10963346393

Details

  • 29 of 31 (93.55%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 82.67%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/middleware/user.js 29 31 93.55%
Files with Coverage Reduction New Missed Lines %
src/middleware/user.js 3 82.59%
Totals Coverage Status
Change from base Build 10784039634: 0.004%
Covered Lines: 22330
Relevant Lines: 25590

💛 - Coveralls

@shinyumh shinyumh self-requested a review September 20, 2024 17:18
Copy link

@shinyumh shinyumh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@bencondemi bencondemi changed the title Imported tpl files from the commit linked in Slack by Prof. Hilton Imported tpl files from the commit linked in Slack by Prof. Hilton and added names to the README Sep 20, 2024
@bencondemi bencondemi merged commit 31b5959 into f24 Sep 20, 2024
1 check passed
@bencondemi bencondemi deleted the bc/tpls branch September 20, 2024 17:26
@bencondemi bencondemi self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add team member names to README
3 participants