refactor(legacy): proper mc.thePlayer -> player
#3055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very buggy, can anyone help me fix? |
|
chop chop |
|
I deem this pull to be unnecessary, but if you still want to continue it, feel free to do so (whenever you feel ready, ping me to merge it) but unfortunately I won't be helping on this pull, since tbf this is quite unnecessary.. |
|
I think so too. Accessing nullable variables in certain situations can cause a lot of errors, this works for nextgen (because we do not run certain things without safe environment), but I do not think this is true for legacy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make development easier, and code smaller.