Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Award Nomination scenarios. OA Intake scenario #352

Merged
merged 28 commits into from
Dec 31, 2024
Merged

Conversation

alenaminsk
Copy link
Collaborator

No description provided.

@alenaminsk alenaminsk changed the title updated Award Nomination scenarios. NCCR scenario updated Award Nomination scenarios. OA Intake scenario Dec 20, 2024
Copy link
Collaborator

@matakevin matakevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the commented line in your feature file!

Scenario: Validate ITO approve test case from Native View

@ITAONativeApprove
Scenario: Validate ITO approve test case from Native View
Given User opens IT Procurement Governance Application in browser
When User Logins to the application
Then Go to Native view
# Then Click on Elevate Permision
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line not needed anymore?

@@ -179,8 +178,8 @@ public void verifyWatcherAdded(String watcher) {
* upload a file
*/
public void uploadFile(){
awardNominationPage.addAttachmentButton.sendKeys("C:\\Users\\nekrashevicha2\\Desktop\\projectIDEA\\src\\test\\java\\ServiceNow\\AwardNomination\\Attachments\\AWARD_NOMINATION.docx");
CommonUtils.clickOnElement(awardNominationPage.addAttachmentButton);
awardNominationPage.chooseFileButton.sendKeys("C:\\Users\\nekrashevicha2\\Desktop\\projectIDEA\\src\\test\\java\\ServiceNow\\AwardNomination\\Attachments\\AWARD_NOMINATION.docx");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work during our regression tests because this path only exists on your system. You need to make this path relative to wherever the project folder is located

nekrashevicha2 added 3 commits December 23, 2024 09:25
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

nekrashevicha2 added 2 commits December 23, 2024 09:51
Copy link
Collaborator

@katm007 katm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@@ -9,6 +9,8 @@
import org.testng.Assert;
import java.util.ArrayList;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line on line 11

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Collaborator

@lfcabrera14 lfcabrera14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Mariachaudhry Mariachaudhry merged commit 5f0c1c0 into master Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants