docs: fix example of .blocks.det to .hap conversion in API docs
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryarm
changed the title
.blocks.det to .hap conversion in API docs
|
The tests successfully pass on my local machine, so I think the CI is just having another hissy fit The CI is revamped in #207 , so merging that will probably resolve these issues, anyway. Let's just wait until that's merged before trying to merge this |
aryarm
changed the title
.blocks.det to .hap conversion in API docs.blocks.det to .hap conversion in API docs
aryarm
changed the title
.blocks.det to .hap conversion in API docs.blocks.det to .hap conversion in API docs
Sounds good to me, I'll approve anyway so you can merge when ready. |
mlamkin7
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #235
There were a few bugs in the blocks2hap example in the API docs!
In d06d50a, we fix those bugs. And in aa5d4ef, we convert that example code into a test so we can properly maintain it going forward.