Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major Refactoring #85

Merged
merged 88 commits into from
May 4, 2024
Merged

Major Refactoring #85

merged 88 commits into from
May 4, 2024

Conversation

Taewan-P
Copy link
Member

@Taewan-P Taewan-P commented May 1, 2024 •
edited

Describe your Pull Request

  • Optimize file structures to best practice
  • Apply React Query and remove lines of useEffect
  • Add custom subway API for better accuracy
  • Remove useless codes and duplicates
  • Upgrade package libraries to latest version (React 18.3.1, Vite 5.2.10, etc...)
  • Convert all components to Styled Components for consistency

Additional content

Any additional comments? 😁

devITae and others added 30 commits October 11, 2023 13:56
@devITae
Fix UI for Cheongnyangni Station
313dcf9
@devITae
Fix api error correction
c991bcd
@Taewan-P
Separate data types
cc6eb20
@Taewan-P
Rename data type filenames to camelcase
ff85dce
@Taewan-P
Merge index.ts into one
703d5e0
@Taewan-P
Upgrade yarn pkg manager to 4.0.0
0a8ee07
@Taewan-P
Add missing data types
ac9b214
@Taewan-P
Use extracted data types
9938426
@Taewan-P
Update package zip hashes (yarn 4.0.0 upgrade)
a402287
@Taewan-P
Extract data types used in Notice component
9ca0cb2
@Taewan-P
Extract data type used in Modal component
2b01732
@Taewan-P
Set path alias to src/app
0fe6a44
@Taewan-P
Use alias for data type import
6e6a0c2
@Taewan-P
Add network data type
b07ea56
@Taewan-P
Add basic api handler
7725aff
@Taewan-P
Add shuttle bus api handler
08784fe
@Taewan-P
Add more values to shuttle related data types
cc35245
@Taewan-P
Refactor shuttle api call & logic
89d92ec
@Taewan-P
Add missing hook dependency
0610aac
@Taewan-P
Update workflow actions to latest version
eff404a
@Taewan-P
Update node version to required level
8a02a04
@Taewan-P
Update react-query package to v5
93689d3
@Taewan-P
Add timeout to axios client
5b649b2
@Taewan-P
Upgrade queryclient to latest version
3f81dc4
@Taewan-P
Add setting API & shuttle API
aa3e991
@Taewan-P
Change response type to actual data
709d084
@Taewan-P
Lift up useEffect & use react-query for api fetching in Card component
a021f28
@Taewan-P
Save week and season value to local storage
f595312
@Taewan-P
Reconfigure all dependencies
333292e
@Taewan-P @kcyoow
Update tailwind,twin.macro,styled-components
abead80 
Credits to @kcyoow

Co-Authored-By: kcyoow <[email protected]>
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 1, 2024 •
edited

Deploying hybus-genesis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e6284f
Status: ✅  Deploy successful!
Preview URL: https://aa942a9e.hybus-genesis.pages.dev
Branch Preview URL: https://dev-major-refactor.hybus-genesis.pages.dev

View logs

github-actions[bot]
github-actions bot reviewed May 1, 2024
View reviewed changes
src/app/components/shuttle/Shuttle.tsx Outdated Show resolved Hide resolved
src/app/components/shuttle/Shuttle.tsx Outdated Show resolved Hide resolved
@Taewan-P
Copy link
Member Author

Taewan-P commented May 1, 2024

Bypassing reviewdog / misspell due to the GitHub API issue

@Taewan-P Taewan-P marked this pull request as ready for review May 3, 2024 19:31
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

Check out your Lighthouse Report: https://lighthouse.hybus.app/app/projects/hybus-production/dashboard

devITae
devITae approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@devITae devITae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devITae devITae merged commit 5c82e98 into main May 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@devITae devITae devITae approved these changes

Assignees

@Taewan-P Taewan-P

Labels
enhancement New feature or request feature Feature development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taewan-P @devITae @kcyoow