-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create go.mod #57
base: master
Are you sure you want to change the base?
Create go.mod #57
Conversation
Note: The https://github.com/jezek/xgb repository hasn't the |
Hi @jezek , is your fork compatible with BurntSushi's fork? The Arch Linux repo is maintaining a package which currently uses this fork as upstream. Maybe I can file an issue to request changing the source to your fork? Arch's build system does require a |
@XieJiSS Yes, my fork is fully compatible. I've only forked and added a memory leak fix + some tests (Edit: also some examples were merged). I've added a |
Hi @jezek, FYI I've created a bug report for Arch Linux at https://bugs.archlinux.org/task/73754. For packaging purpose you may need to add a release or tag in your repo, would that be fine? Thanks! |
@jezek I want to use the xgbutils, which is based on the xgb, does that mean the fixes you made in your repo are still a problem in the xgbutil? |
|
@tobigiwa Yes, the fixes I made to my fork of You can (one of these):
|
Ooh... I didn't know you had a fork of xgbutil, that's what I'll be doing. Thanks. |
@jezek I'm currently working on a project with X11, might if I disturb you a bit with questions...? |
I don't know the workings of xgbutil. I used only xgb a long time ago to spawn a window with an image (and some other stuff), found a bug, made a PR. It was not accepted (too many chages), so I forked and used it for my side project. It was a long time ago and I don't remember much. I'm afraid I won't be any help for you. Have fun figuring it out. ;) |
Without a
go.mod
, the build fails with error:Note that since go 1.16, the
go
command will build packages in module-aware mode by default, see: https://go.dev/blog/go116-module-changes#modules-on-by-default