Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitch's soft counter added #124

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

abu271
Copy link
Contributor

@abu271 abu271 commented Mar 13, 2019

Hey Burkus,

I have added Twitch's soft counter towards Echo to the r6OperatorsCounter.json file.

Thanks,

Abu

Copy link
Owner

@BurkusCat BurkusCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Abu! Thanks for contributing :)

Apart from this change, we probably wouldn't be looking to accept any more operator relationship additions. The reason being that the site's performance is very low (as you may have noticed). The more relationships we add the slower it gets which is why we want don't want to be adding too many at the moment.

I'm not sure if any of the other tickets would interest you but there are tickets for improving readability of the site, adding new features, improving performance (the site's biggest need) #8 etc. Or, if you can think of anything that might improve the site, feel free to create an issue of your own and we'll let you know if it is a good thing to work on!

Again, many thanks for contributing this change 👍

@BurkusCat BurkusCat merged commit 80f86eb into BurkusCat:master Mar 14, 2019
@abu271
Copy link
Contributor Author

abu271 commented Mar 14, 2019

Hey Burkus,

I am glad I could help 👍 . This is a really cool project, I play a little bit of R6 myself (but I'm not that good at it). Right now I am trying to learn some of the tech you are using, especially Neo4j, I never worked with a graphical database before.

I have two questions for you:

  1. Why is that when you add more relationships the website becomes more slow?
  2. I am kinda new to programming, I develop on windows. Would that cause any conflicts?

I look forward to working on this cool project with you.

@BurkusCat
Copy link
Owner

  1. So I'm still not 100% sure the exact reasons why the performance drops so much. I've seen other Neo4jd3 projects where they have similar numbers of nodes + relationships where the framerate is good. But I believe it is because the physics simulation is quite complex. There are so many nodes colliding with each other, pushing each other away so they aren't too close, pulling each other together with the lines etc. Each relationship added means there are more things to calculate so things start to get slower.

The main part of the slow performance I think is the rendering of the lines between the operators. These lines are graphics that are rotated, stretched and moved around many times a second. This can be difficult for the browser to render fast.

You can see some of our thoughts so far on the performance issues on these tickets: #111 #8

  1. Nope this is fine. I use Windows as well to program :) Something quite nice about web development is everyone can use whatever they want to make websites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants