fix: remove deprecated dependencies in core package #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db7cf39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit db7cf39. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
rqzheng2015
force-pushed
the
fix/upgrade_dependency_0318
branch
from
1701df9
to
01cbcd6
Compare
rqzheng2015
force-pushed
the
fix/upgrade_dependency_0318
branch
from
01cbcd6
to
db7cf39
Compare
|
Hi @samijaber, please check this PR if you are free, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove 2 deprecated dependencies:
vueand@babel/plugin-proposal-class-propertiesWhy?
@babel/plugin-proposal-class-propertiesis deprecated, which can be seen in here.Solution
Vue
There are just 1 place in core's code to import vue for its ts definition. So we could copy them and remove the import of
vue2@babel/plugin-proposal-class-properties
As there were 0 places to import
@babel/plugin-proposal-class-properties, we could just remove the import of it.