fix column names with spaces for relationship columns #15379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
shogunpurple
force-pushed
the
budi-8973-rows-being-deleted-after-changing-tables-or-going-on
branch
from
861bc53 to
f07b96d
Compare
shogunpurple
force-pushed
the
budi-8973-rows-being-deleted-after-changing-tables-or-going-on
branch
from
f07b96d to
df2f6cf
Compare
shogunpurple
force-pushed
the
budi-8973-rows-being-deleted-after-changing-tables-or-going-on
branch
2 times, most recently
from
6727773 to
0b8d024
Compare
shogunpurple
force-pushed
the
budi-8973-rows-being-deleted-after-changing-tables-or-going-on
branch
from
0b8d024 to
3bd56bd
Compare
adrinr
approved these changes
Jan 16, 2025
samwho
approved these changes
Jan 16, 2025
shogunpurple
deleted the
budi-8973-rows-being-deleted-after-changing-tables-or-going-on
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Column names with spaces at the end were being trimmed in some places by knex, causing the query to fail and no rows to be returned. We need to wrap them in a
knex.rawso the spaces are preservedAddresses