BindingPanel typing improvements
#15372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…e into binding-ts-improvements
adrinr
reviewed
Jan 16, 2025
packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
Outdated
Show resolved
Hide resolved
packages/builder/src/components/common/CodeEditor/CodeEditor.svelte
Outdated
Show resolved
Hide resolved
packages/builder/src/components/common/bindings/EvaluationSidePanel.svelte
Show resolved
Hide resolved
adrinr
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the debugging work I've started by typing some of the components that will need updated to support the JS logging functionality - this includes
BindingPanel.svelte,EvaluationSidePanel.svelteandCodeEditor.svelte- there is a few other bits that needed updated but these are the main components focused on here.