Convert portal environment store to TS #15285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
aptkingston
changed the title
PClmnt
reviewed
Jan 3, 2025
|
|
||
| async loadVariables() { | ||
| if (get(licensing).environmentVariablesEnabled) { | ||
| const envVars: string[] = (await API.fetchEnvironmentVariables()) |
There was a problem hiding this comment.
NAB: Don't think we need to have this type annotation here do we? string[] will be inferred from the API? I could be wrong
There was a problem hiding this comment.
We do actually, only because the API response type is a custom thing (something along the lines of FetchEnvironvmentVariablesResponse) which is itself just aliased to a string[], but I'd rather store a normal string array in the store instead of the response type, hence the casting here.
PClmnt
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert environment store to TS