Typing automation store #15227
Open
Typing automation store #15227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
|
||
| const initialAutomationState = { | ||
| interface BlockDefinitions { |
There was a problem hiding this comment.
We should move these definitions where possible into @budibase/types under types/src/ui/stores - the store definition can stay within the store, but if theres a chance a definition is needed outside of the store I think it should be within the type package, rather than being exported from here, makes finding types a lot easier!
PClmnt
commented
Dec 20, 2024
| @@ -94,6 +94,7 @@ | |||
| "@sveltejs/vite-plugin-svelte": "1.4.0", | |||
| "@testing-library/jest-dom": "6.4.2", | |||
| "@testing-library/svelte": "^4.1.0", | |||
| "@types/shortid": "^2.2.0", | |||
There was a problem hiding this comment.
Had to add types for shortid as it was complaining, so the lockfile changed massively. In case anyone was wondering about the PR size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types the automation store. There are still quite a few
anyin here but I thought I'd get the PR up