Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 5.7.2. #15126

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Update to TypeScript 5.7.2. #15126

merged 4 commits into from
Dec 5, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Dec 5, 2024

Description

For reasons that aren't clear to me, this also required some fiddling with testcontainers.

  1. I disabled the ryuk testcontainers feature. This cleaned up images after tests had finished, but we don't need it because we tend to reuse images or delete them manually. I did this because for whatever reason it was reading from the wrong Docker socket on my local machine all of a sudden, and failing the backend-core tests.
  2. I upgraded to testcontainers 10.16.0 in an attempt to fix the above. It didn't work, but I figured I'd stick on this version anyway. It allows us to get rid of the code that removes stopped images, because the latest version of testcontainers can restart stopped images.

Copy link

qa-wolf bot commented Dec 5, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Dec 5, 2024
@samwho samwho marked this pull request as ready for review December 5, 2024 16:20
@samwho samwho requested a review from a team as a code owner December 5, 2024 16:20
@samwho samwho requested review from adrinr and removed request for a team December 5, 2024 16:20
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwho samwho enabled auto-merge December 5, 2024 16:40
@samwho samwho merged commit 9231b58 into master Dec 5, 2024
19 checks passed
@samwho samwho deleted the typescript-5.7 branch December 5, 2024 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants