-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats #109
base: main
Are you sure you want to change the base?
Stats #109
Conversation
Changed charts
Thanks a lot for the PR!
You can do a map between Ergast's driverId and the one present in the URLs (in |
No worries, yake your time
I was planning on extending it indeed, but was too lazy in the end. |
So I just tried to run your Pr, but there are some bugs in Syncfusion's charts package. |
Hmm it used to work a month ago but I am having trouble now as well. I was working on the latest stable back then, but not sure if a Flutter upgrade broke anything. Update: I upgrade version (not the one that is used for this PR) and did a flutter clean ; flutter pub get and flutter run -v from terminal and got it running on my mobile I now have the latest stable: |
Thanks, now it is working. I think this would be a good start, but would need some changes: |
This is by far not done, but to give you a look at what I was thinking about. This is for now only points comparison but you can change which dataset is show on line 23 of chart.dart.
I did refactor a bit and re-used some of your widgets. So it's a bit bigger then I would like. You don't have to merge it yet but I like you to have a look already. If you don't like it just reject it.
Only stats of Max Verstappen works for now because driverId's is not consistent, for that reason not all driver profile work when you click on a point in the graph. I'll try to correct it later.