feat(doc): add github action to check markdown links #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonperron
force-pushed
the
fix/boaviztapi-359
branch
from
e5adf17 to
59aaeb9
Compare
|
Let's wait for #360 to be merged, the current workflow identify issues and will be blocking if enabled. |
|
Thank you for your contribution. Can we limit workflow execution only when a change is made to the /docs/ folder? |
* Only planned to run on push and pull request on main boaviztapi-359
jonperron
force-pushed
the
fix/boaviztapi-359
branch
from
59aaeb9 to
d9e413b
Compare
|
Updated following your feedback @da-ekchajzer 👍 |
|
Works for me thank you very much ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #359
Changes
Additional info
According to github, this workflow will have to be setup in the branch protections rules if we want it to be not mandatory for merge.
I have not found a "mandatory" keyword in https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions
Tests
Tested in jonperron#1