refactor(remove.ts): rename DomCookieOptions to RemoveDomCookieOptions

feat(cookie.ts): add RemoveDomCookieOptions type definition
Bluzzi · Apr 25, 2023 · 3a5634c · 3a5634c
1 parent ec2ac51
commit 3a5634c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/dom/remove/remove.ts b/src/dom/remove/remove.ts
@@ -1,9 +1,9 @@
-import type { DomCookieOptions } from "#/typing/cookie";
+import type { RemoveDomCookieOptions } from "#/typing/cookie";
 import { serializeCookie } from "#/http/serializer";
 import { CookieMaxAge } from "#/utils/duration";
 import { isCookieEnabled } from "#/utils/cookie";
 
-export function removeCookie(name: string, options?: Omit<DomCookieOptions, "maxAge">): void {
+export function removeCookie(name: string, options?: RemoveDomCookieOptions): void {
   isCookieEnabled();
 
   document.cookie = serializeCookie(

diff --git a/src/typing/cookie.ts b/src/typing/cookie.ts
@@ -23,4 +23,6 @@ type CookieOptions = {
 }
 
 export type DomCookieOptions = Omit<CookieOptions, "httpOnly">;
-export type HttpCookieOptions = CookieOptions;
+export type HttpCookieOptions = CookieOptions;
+
+export type RemoveDomCookieOptions = Pick<CookieOptions, "domain" | "path" | "sameSite">;