Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logs in case of error when staging emodels #14

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Improve logs in case of error when staging emodels #14

merged 3 commits into from
Jun 11, 2024

Conversation

GianlucaFicarelli
Copy link
Contributor

Print more descriptive logs when staging emodels in case of:

  • mechanisms without id (print warning, do not raise)
  • morphology without id (raise)

eleftherioszisis
eleftherioszisis approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GianlucaFicarelli GianlucaFicarelli merged commit c0ee2a5 into BlueBrain:main Jun 11, 2024
5 checks passed
@GianlucaFicarelli GianlucaFicarelli self-assigned this Jun 11, 2024
@GianlucaFicarelli GianlucaFicarelli deleted the improve_logs branch June 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherioszisis eleftherioszisis eleftherioszisis approved these changes

Assignees

@GianlucaFicarelli GianlucaFicarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GianlucaFicarelli @eleftherioszisis