Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Give possibility to change mpiexec configuration for integration tests #699

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 29, 2021

Some mpiexec version does not have the option -n, so it should be configurable

@pramodk
Copy link
Collaborator

pramodk commented Dec 20, 2021

@alkino : could you check failing CI?

@codecov-commenter
Copy link

Codecov Report

Merging #699 (93a6567) into master (7b0b6d9) will decrease coverage by 2.02%.
The diff coverage is n/a.

❗ Current head 93a6567 differs from pull request most recent head 7295f4a. Consider uploading reports for the commit 7295f4a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   55.51%   53.49%   -2.03%     
==========================================
  Files         107      107              
  Lines        8947     8947              
==========================================
- Hits         4967     4786     -181     
- Misses       3980     4161     +181     
Impacted Files Coverage Δ
coreneuron/network/multisend_setup.cpp 44.48% <0.00%> (-30.52%) ⬇️
coreneuron/network/multisend.cpp 42.50% <0.00%> (-19.00%) ⬇️
coreneuron/mpi/lib/mpispike.cpp 58.82% <0.00%> (-5.89%) ⬇️
coreneuron/utils/progressbar/progressbar.cpp 82.95% <0.00%> (-5.69%) ⬇️
coreneuron/io/nrn_setup.cpp 82.15% <0.00%> (-3.54%) ⬇️
coreneuron/network/netcon.hpp 51.61% <0.00%> (-3.23%) ⬇️
coreneuron/network/netcvode.cpp 71.24% <0.00%> (-2.88%) ⬇️
coreneuron/network/partrans.cpp 93.02% <0.00%> (-2.33%) ⬇️
coreneuron/io/output_spikes.cpp 87.50% <0.00%> (-1.48%) ⬇️
coreneuron/sim/fadvance_core.cpp 82.82% <0.00%> (-0.62%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0b6d9...7295f4a. Read the comment docs.

@alkino alkino closed this Dec 23, 2021
@alkino alkino reopened this Dec 23, 2021
@pramodk
Copy link
Collaborator

pramodk commented Mar 2, 2022

@alkino : converting this to draft until CI is fixed. If you think this is not relevant now, feel free to close this.

@pramodk pramodk marked this pull request as draft March 2, 2022 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants