use the correct purpose when choosing hw device #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled When for some reason the hw device fails setup (Electron-Cash#170 for instance), make sure the hw selection is done again with the same purpose. This prevents calling `on_device(purpose=HWD_SETUP_NEW_WALLET)` when the real purpose is to decrypt an existing wallet file (`HWD_SETUP_DECRYPT_WALLET`) Closes Electron-Cash#168
|
Note that this is also fixed in one of the backport commits in #162, but I'm not sure that I want to merge that PR before the next release, so it is best to fix that bug immediately on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When for some reason the hw device fails setup (#170 for instance), make sure the hw selection is done again with the same purpose. This prevents calling
on_device(purpose=HWD_SETUP_NEW_WALLET)when the real purpose is to decrypt an existing wallet file (HWD_SETUP_DECRYPT_WALLET)Closes #168