Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Spanish translation for v1.3.0 #78

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

rcastelo
Copy link
Contributor

Updates to the Spanish translation of the latest CoC v1.3.0 of the en-US.Rmd and on the proposed issue #77

@llrs @mireia-bioinfo @estepi could you double check the translations I made? Most of the edits are at the end of the first subsection, about ethical partnerships.

Thanks!

@llrs
Copy link
Contributor

llrs commented Jan 16, 2024

I don't find any issue. It is a pity that now there are two sentences in the same line (30).

@rcastelo
Copy link
Contributor Author

Not sure I understand your concern, is this something I/we have to do something about it?

@llrs
Copy link
Contributor

llrs commented Jan 16, 2024

No, it is a change in the English-US version

@kevinrue
Copy link
Collaborator

Well spotted @llrs

It is a pity that now there are two sentences in the same line (30).

Note that it's not something I introduced. I just checked the diff and it was there before. I'll fix it.

@llrs
Copy link
Contributor

llrs commented Jan 16, 2024

Yes, I might have missed it when I reviewed the document as part of the CoC.

@kevinrue
Copy link
Collaborator

On a separate note, @rcastelo would you mind adding a new commit in this branch to also update the spanish version number in the index page?
https://github.com/Bioconductor/bioc_coc_multilingual/blob/main/index.Rmd#L43

Small detail, everyone forgets it and I'm not sure if there's a simple way to automate it. I don't want to over-engineer things.

@kevinrue
Copy link
Collaborator

Also, pull this branch locally before working on it because I've fixed the newline issue on the en-US version and updated this branch on github. Thanks!

@rcastelo
Copy link
Contributor Author

Ok @kevinrue, done, I think we should be ready to go with the Spanish translation of CoC v1.3.0.

@kevinrue kevinrue merged commit e32a8d3 into Bioconductor:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants