Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete printFn from options sent to zprint #2631

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Sep 22, 2024

What has changed?

Deleting printFn from the options we send along to zprint. To make it not croak when this option is specified by the user. (It is not used by zprint.)

See also:

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested a review from bpringe September 22, 2024 15:42
Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 9404193
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/66f040fd7c9ebd0008e09fa0
😎 Deploy Preview https://deploy-preview-2631--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ merged commit eb46f35 into dev Sep 22, 2024
5 checks passed
@PEZ PEZ deleted the 2621-pretty-printfn-terminal-output branch September 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant