Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(key_management_endpoints.py): enforce user_id / team_id checks on key generate #7437

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

krrishdholakia
Copy link
Contributor

Title

fix(key_management_endpoints.py): enforce user_id / team_id checks on key generate s/o @mirodrr2

Relevant issues

Fixes #7336

Type

🐛 Bug Fix

Changes

Enforces on /key/generate that user is only assigning user_id of their own, or if team_id, then the key must belong to that team (not applied if user is a proxy admin)

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Screenshot 2024-12-26 at 7 00 36 PM

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:26pm

@krrishdholakia krrishdholakia merged commit 40e2a95 into main Dec 27, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Internal Users able to generate keys using other user's user_id (Vulnerability)
1 participant