Update map_finish_reason #7264
Open
Update map_finish_reason #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ishaan-jaff updated this function |
| "SPII": "content_filter", | ||
| } | ||
|
|
||
| return finish_reason_mapping.get(finish_reason, finish_reason) |
There was a problem hiding this comment.
would this return None if unmapped?
There was a problem hiding this comment.
This returns the finish_reason if unmapped, just like the original definition.
The second value of get provides the default value if the key does not exist
There was a problem hiding this comment.
nice - can we add a unit test for this, maybe here -
if you can share a screenshot of it passing, this pr should be good to merge!
|
@krrishdholakia Ready for merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Update mapping helper function that converts from api specific finish reasons to a standard set
Type
🧹 Refactoring
📖 Documentation
Changes
Documented the source
Made it clearer what the mappings are