Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Initial Calendar Commit #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

markpernotto
Copy link

@markpernotto markpernotto commented Oct 18, 2019

This initial PR provides a basic react-based calendar that we can work with; allows for the inclusion of multiple event endpoints, is extensible with regard to stylings, and offers some basic tools we can begin working with.

Updating with screenshot per @ctsstc request
Screen Shot 2019-10-18 at 7 03 54 AM

Also added Link in header component && updated styling for readability.

Adds moment && react-big-calendar dependencies.

@ctsstc
Copy link
Member

ctsstc commented Oct 18, 2019

Looks like the snapshot needs to be updated to get tests passing.

Could you throw a screenshot in the main PR -- not necessary but would be nice :)

Awesome work! Thanks

@ctsstc
Copy link
Member

ctsstc commented Oct 18, 2019

@kcloud99 @russtaylor maybe we want to disable test snapshots? Do you guys normally use them? I know some people hate them and find them to be a pain and useless¿

@markpernotto
Copy link
Author

markpernotto commented Oct 18, 2019

A few other notes I should probably mention for future development:

In this initial commit, Events are passed in via an array of objects from a file: fakeData.js. This is mostly from react-big-calendar's examples, but I've added a few other key/val pairs to flesh out a few of the ways we could use this board to represent varying calendars.

A selected function has been implemented to capture the clicked on event. Currently, it just writes the object selected to the console.

This Calendar module we're using can only be implemented through either moment or globalize. I went with the former because I'm more familiar with the library as a whole, but I don't actually have a preference.

@markpernotto
Copy link
Author

Updated snapshot - or at least attempted to.

@ctsstc
Copy link
Member

ctsstc commented Oct 18, 2019

Hrmm odd,, it failed, did you try running the command with npx to scope it to the project's version. Although if there's a newer version maybe we should look into using it, but that also sounds like it could be a nightmare -- at least the project is still young to make these choices.

@markpernotto
Copy link
Author

@ctsstc yeah, I did that wrong. Reverting previous commit and running yarn test. Just a moment

@markpernotto
Copy link
Author

@ctsstc I think that did it. Thanks for the help there.

@russtaylor
Copy link
Collaborator

@ctsstc I don't know about keeping the snapshots, I personally haven't used them before. It seems like they're more trouble than they're worth, but that's just on the surface.

@jweinsteincbt
Copy link

👍
🚢 :shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants