Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Structured out basic scaffolding & Forms & Routing & React-like File System #20

Merged
merged 7 commits into from
Oct 16, 2019
Merged

Conversation

JacobMGEvans
Copy link
Contributor

  • Added Reach Router which focuses on accessibility

  • Added Formik for any forms and added a basic example

  • Scaffolded out some basic React-like file structure

  • Didn't add too much since I saw storybook added in another PR which is a great tool that should be utilized for building out the components

  • Updates to packages

@JacobMGEvans JacobMGEvans changed the title Structures out basic scaffolding Structured out basic scaffolding & Forms & Routing & React-like File System Oct 11, 2019
@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Oct 11, 2019

I added .babelrc and .eslintrc

  • The babel plugins and packages might be a little redundant because of react-scripts
    however, if needed they can just be removed
  • ESlint and Prettier, however, are not redundant and are fantastic powerful tools for coding.

Some of this in the Pull Request can help with #1 and #4

@JacobMGEvans
Copy link
Contributor Author

Resolved Merge Conflicts

@JacobMGEvans
Copy link
Contributor Author

I apparently did not keep this branch updated lol, I fixed more inconsistencies with the base master branch.

@JacobMGEvans
Copy link
Contributor Author

So there is a way to utilize Formik AND the Netlify Forms just a heads up that is a powerful combination.

@JacobMGEvans
Copy link
Contributor Author

@kcloud99 @russtaylor @JWTappert @ctsstc Not sure who does the reviews... Or if any of this I did interest anyone?

@russtaylor
Copy link
Collaborator

Hey @JacobMGEvans - I'm not super familiar with everything that you added, but upon looking it up, I think it all makes sense. So I'm good with the changes. I don't know if someone else wants to weigh in - if no one does in the next day or so, I'll get this merged in.

@JacobMGEvans
Copy link
Contributor Author

@russtaylor I am more than happy to also discuss any of it. 😁

@JacobMGEvans
Copy link
Contributor Author

I started prototyping out some calendar with material ui picker 🙂

@JacobMGEvans
Copy link
Contributor Author

Hey, @russtaylor just wanted to check if you have any questions or things you'd like to discuss the technologies. 😁

@russtaylor russtaylor merged commit 899d0f7 into BendJS:master Oct 16, 2019
@russtaylor
Copy link
Collaborator

I was just bein' slow! But this lgtm overall. :-)

@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Oct 16, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants