Skip to content
This repository has been archived by the owner on Sep 5, 2022. It is now read-only.

Added support for remote hosts, fixed "performance" leak #27

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Sickboy78
Copy link

Added the support to get system stats from remote hosts.
Since commands to get stats differ from system to system, I made the command and also the split and replace commands configurable.

There also was a problem with the interval timers in the node_helper.js. With every page request new timers where created but never stopped/deleted. This resulted in increasing faster updates and also increasing performance and memory consumption until raspberry crashes.
I fixed this by moving the interval timers to the client side, so they are resetted with each page request.

Sickbart added 5 commits March 31, 2019 21:37
added host and remoteUser config
added support for other operating systems
moved timers from node_helper to MMM-Systemstats.js
updated screenshot
@BenRoe
Copy link
Owner

BenRoe commented Apr 11, 2019

Wow nice feature, but a lot of code changes. I have to test this first.
Btw can you split the configuration table in the readme into two sections (basic & advance/remote).

@BenRoe BenRoe added the feature New Features label Apr 11, 2019
@Sickboy78
Copy link
Author

Ok, I'm gonna have a look at it.

@Sickboy78
Copy link
Author

Hi Ben, I splitted the configuration into basic and advanced config values.
But I had to remove the config.unit value, since the commands are no longer hard coded in this version, but are also configuration values. I added the commands for the different units as example values in the readme.
If you want to keep the units or keep things simple, I can understand that. So if you dont want to merge the changes, please tell me, then I will rename the fork (e.g. MMM-SystemStatsRemote) and keep it as a separate module.
Happy Easter!

@BenRoe
Copy link
Owner

BenRoe commented May 5, 2019

Thank you @Sickboy78 currently i am a bit busy. First impression looks good.
Have setup a mm and test it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants