Move QuickPick constants to root.php and update references

[N6REJ]

PR Type

Enhancement

---

Description

• Moved QuickPick constants from class file to centralized root.php for better maintainability
• Converted all application constants from define() to const for better performance and consistency
• Organized constants into logical groups with clear comments
• Updated all references to use new constant names with QUICKPICK_ prefix

---

Changes walkthrough 📝

Relevant files

Enhancement

class.action.quickPick.php Refactor QuickPick constants and references                            core/classes/actions/class.action.quickPick.php Removed hardcoded API constants (API_KEY, API_URL, JSON_URL) Updated references to use new constants from root.php Simplified code by removing redundant URL variable +3/-13    root.php Centralize application constants and add QuickPick configs core/root.php Changed define() to const for all application constants Added QuickPick-related constants (API_KEY, API_URL, JSON_URL) Improved code organization with grouped constants +17/-9

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns Sensitive information exposure: The API key '4abe15e5-95f2-4663-ad12-eadb245b28b4' is hardcoded directly in the source code (root.php). This key should be moved to a secure configuration file that is not tracked in version control to prevent unauthorized access and potential misuse.

⚡ Recommended focus areas for review Sensitive Data The API key is hardcoded in the source code. Consider moving sensitive credentials to a secure configuration file that is not tracked in version control. const QUICKPICK_API_KEY = '4abe15e5-95f2-4663-ad12-eadb245b28b4';

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add JSON response validation to ensure data integrity before processing Validate the JSON response before using it by checking both the HTTP response code and JSON validity to ensure the received content is actually valid JSON data. core/classes/actions/class.action.quickPick.php [183-187] $jsonContent = file_get_contents( QUICKPICK_JSON_URL ); if ( $jsonContent === false ) { throw new Exception( 'Failed to fetch JSON content from the URL.' ); +} +if (json_decode($jsonContent) === null && json_last_error() !== JSON_ERROR_NONE) { + throw new Exception('Invalid JSON content received'); +} + Apply this suggestion Suggestion importance[1-10]: 9 Why: This is a critical security and reliability improvement that validates JSON data integrity before processing, preventing potential crashes or unexpected behavior from malformed data.	9
General	Enhance error handling for network requests to provide more detailed error information Add error handling for the file_get_contents() call to handle network issues or invalid URLs. The current implementation only checks if the result is false but doesn't provide specific error details. core/classes/actions/class.action.quickPick.php [183-187] -$jsonContent = file_get_contents( QUICKPICK_JSON_URL ); +$context = stream_context_create(['http' => ['ignore_errors' => true]]); +$jsonContent = @file_get_contents( QUICKPICK_JSON_URL, false, $context ); if ( $jsonContent === false ) { - // Handle error if the file could not be fetched - throw new Exception( 'Failed to fetch JSON content from the URL.' ); + $error = error_get_last(); + throw new Exception( 'Failed to fetch JSON content: ' . ($error['message'] ?? 'Unknown error') ); Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion significantly improves error handling by providing detailed error messages from failed network requests, which is crucial for debugging and maintenance in a production environment.	8
Security	Add URL validation to prevent security issues with malformed URLs Add URL validation for the QUICKPICK_JSON_URL constant before making the request to prevent potential security issues with malformed URLs. core/classes/actions/class.action.quickPick.php [132] +if (!filter_var(QUICKPICK_JSON_URL, FILTER_VALIDATE_URL)) { + throw new Exception('Invalid URL format'); +} $headers = get_headers( QUICKPICK_JSON_URL, 1 ); Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion adds important URL validation to prevent security issues, though the impact is somewhat mitigated since the URL is already defined as a constant in the application.	7