Implement visibility reduction mods #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't used publicly anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct port of Mania's visibility reduction mods to Rush, except horizontal.
This is not quite complete yet, as it is currently very inefficient due to overlapping BufferedContainers.I'm looking at two potential resolutions, which involves either proxying the effects/judgements, so that they aren't drawn within the bufferedContainer (allowing a single cover to cover all HitObjectContainers); Or proxying the HitObjectDrawables out to a shared container. I'm prolly gonna take the latter option.
I've opted to detach effects and judgements from their respective lanes, and avoid the whole proxying thing altogether, which is reminiscent on how it used to be before the layout refactor. (Extra code needs to be written in the case of proxying hitobjects to ensure their order is consistent, and I don't think the complexity is worth it)