Merge pull request #332 from Beamographic/Hotfix-replays

Fix replays not being perfect
Beamographic · Oct 26, 2023 · 1d96bb5 · 1d96bb5
2 parents 95252d4 + 2e29ea0
commit 1d96bb5
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/osu.Game.Rulesets.Rush/Objects/Drawables/DrawableStarSheet.cs b/osu.Game.Rulesets.Rush/Objects/Drawables/DrawableStarSheet.cs
@@ -172,6 +172,16 @@ protected override void CheckForResult(bool userTriggered, double timeOffset)
             ApplyResult(r => r.Type = r.Judgement.MaxResult);
         }
 
+        private bool iHandledPressed = false;
+
+        protected override void OnApply()
+        {
+            base.OnApply();
+
+            iHandledPressed = false;
+        }
+
+
         public override bool OnPressed(KeyBindingPressEvent<RushAction> e)
         {
             if (!e.Action.IsLaneAction())
@@ -184,13 +194,15 @@ public override bool OnPressed(KeyBindingPressEvent<RushAction> e)
                 return false;
 
             UpdateResult(true);
-            return Head.Judged;
+
+            return iHandledPressed = Head.Judged;
         }
 
         public override void OnReleased(KeyBindingReleaseEvent<RushAction> e)
         {
-            // TODO: HACK FIX FOR HOTFIX, NEEDS FURTHER INVESTIGATION
-            if (!IsInUse)
+            // This is necessary to ensure that holds don't handle releases before handling the press
+            // TODO: Get rid when things are fixed osu side.
+            if (!iHandledPressed)
                 return;
 
             if (AllJudged)