Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add joblib to tests' dependencies #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add joblib to tests' dependencies #545

wants to merge 1 commit into from

Conversation

StrikerRUS
Copy link
Member

Related #542.

With recently added test

m2cgen/tests/test_cli.py

Lines 127 to 131 in b0f76ef

def test_joblib_loading(pickled_model):
mock_args = _get_mock_args(infile=pickled_model, language="go", lib="joblib")
generated_code = cli.generate_code(mock_args).strip()
assert generated_code.startswith("func score(input []float64) float64 {\n")

we need joblib library installed during running API tests.

I believe it's better to install this library explicitly rather than relying on indirect installation of joblib along with scikit-learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants