Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to clean files scripts and file list #2230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Nov 5, 2023

Description

I noticed that all files under lib/* were manually specified in clean_files.txt. I refactored that to the first section.

When running the lint_clean_files.sh script, I receieve the following message:

xargs: warning: options --max-args and --replace/-I/-i are mutually exclusive, ignoring previous --max-args value
...

Because the previuos --max-args / -n value is ignored anyways, and to remove the warning, I removed that option from the script.

Motivation and Context

This simplifes the cleaning files workflow.

How Has This Been Tested?

By executing ./lint_clean_files.sh. And double-checking to ensure that directories are, in fact, supported by clean_files.txt.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant