fix for volumio2 sub-shell sudo permission problems; smaller fixes #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add $user to sudoers before calling bt_pa_config.sh This ensures that $user can run sudo commands without typing any password. The error message, that previously was "swallowed" by `exc` was: "sudo: no tty present and no askpass program specified". - change quotation of "\"arm\"" to '"arm"' to prevent confusing syntax highlightings - add function to restore single saved files This was needed to restore the sudoers file to its previous state after temporarily adding $user to sudoers. - fixed wrong variable name BT_NAME to BluetoothName in bt_pa_config.sh
|
Have any tests been run on this? @wullxz |
|
Sorry, missed your answer here somehow. No, I haven't run any tests apart from testing it in my environment with the latest volumio version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add $user to sudoers before calling bt_pa_config.sh
This ensures that $user can run sudo commands without typing any
password. The error message, that previously was "swallowed" by
excwas: "sudo: no tty present and no askpass program specified".
change quotation of ""arm"" to '"arm"' to prevent confusing syntax
highlightings
add function to restore single saved files
This was needed to restore the sudoers file to its previous state after
temporarily adding $user to sudoers.
fixed wrong variable name BT_NAME to BluetoothName in bt_pa_config.sh
added some config, to-be-compiled source and temporary files to .gitignore to keep commits clean