Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appleseed error when appleseed version > 2.0 #116 #117

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rainy-fall-end
Copy link

update ArtTileCallback class according to Appleseed 1.7+

@Rainy-fall-end Rainy-fall-end changed the title Fix appleseed error when appleseed version > 1.7 Fix appleseed error when appleseed version > 1.7 #116 Mar 21, 2024
@Rainy-fall-end
Copy link
Author

In appleseed master branch,it declares that:

class APPLESEED_DLLSYMBOL ITileCallback
  : public foundation::IUnknown
{
virtual void on_tile_begin(
        const Frame*            frame,
        const size_t            tile_x,
        const size_t            tile_y,
        const size_t            thread_index,
        const size_t            thread_count) = 0;
virtual void on_progressive_frame_update(
        const Frame&            frame,
        const double            time,
        const std::uint64_t     samples,
        const double            samples_per_pixel,
        const std::uint64_t     samples_per_second) = 0;
};
}

In appleseed 2.0+(2.0.5 beta and 2.1.0 beta):

class APPLESEED_DLLSYMBOL ITileCallback
  : public foundation::IUnknown
{
virtual void on_tile_begin(
        const Frame*    frame,
        const size_t    tile_x,
        const size_t    tile_y) = 0;
virtual void on_progressive_frame_update(const Frame* frame) = 0;
}

@Rainy-fall-end Rainy-fall-end changed the title Fix appleseed error when appleseed version > 1.7 #116 Fix appleseed error when appleseed version > 2.0 #116 Mar 24, 2024
@Rainy-fall-end
Copy link
Author

I I simply updated the methods from 1.0+ to 2.0+, I'm not sure if this is still appropriate or if it's necessary to support all appleseed versions.

@drossberg
Copy link
Member

Just some formal remarks:

  • Do not comment out old code, just change what need to be changed. The version control system (i.e. git) does the bookkeeping, as you can see the the "Files changed" tab.
  • You should remove the clutter from your PR ;)

@Rainy-fall-end
Copy link
Author

Just some formal remarks:

  • Do not comment out old code, just change what need to be changed. The version control system (i.e. git) does the bookkeeping, as you can see the the "Files changed" tab.
  • You should remove the clutter from your PR ;)

Thanks for your comments. I have deleted it all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants