Add new Coffee Shop Kata and Coffee Shop Kata solution module #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedyoung
reviewed
Aug 30, 2023
|
|
||
| @Test | ||
| public void testSealedClasses(){ | ||
| assertFalse(CoffeeDrink.class.isSealed()); |
There was a problem hiding this comment.
isSealed() isn't available in Java 8, only 17+.
|
|
||
| @Test | ||
| public void getDrinkItems() { | ||
| List<String> expected = List.of("HOT Americano", "HOT CARAMEL Latte with ALMOND_MILK", |
There was a problem hiding this comment.
List.of is Java 9+, not available in Java 8.
| import static bnymellon.codekatas.coffeekata.food.SpreadType.HERB_GARLIC_CREAM_CHEESE; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
|
|
||
| import bnymellon.codekatas.coffeekata.CoffeeShopOrder; | ||
| import bnymellon.codekatas.coffeekata.Item; | ||
| import bnymellon.codekatas.coffeekata.food.Bagel; |
There was a problem hiding this comment.
Missing import for bnymellon.codekatas.coffeekata.beverage.CoffeeDrink
aqsa505
force-pushed
the
master
branch
7 times, most recently
from
ff56cc4
to
3801156
Compare
donraab
suggested changes
Sep 4, 2023
...java-features-solutions/src/main/java/bnymellon/codekatas/coffeekata/beverage/Americano.java
Outdated
Show resolved
Hide resolved
coffee-shop-kata-solutions/new-java-features-solutions/src/test/java/CoffeeShopTest.java
Outdated
Show resolved
Hide resolved
...ew-java-features/src/main/java/bnymellon/codekatas/coffeekata/beverage/DrinkTemperature.java
Outdated
Show resolved
Hide resolved
...ata/new-java-features/src/main/java/bnymellon/codekatas/coffeekata/beverage/FlavorSyrup.java
Outdated
Show resolved
Hide resolved
...hop-kata/old-java-features/src/main/java/bnymellon/codekatas/coffeekata/CoffeeShopOrder.java
Outdated
Show resolved
Hide resolved
coffee-shop-kata/old-java-features/src/main/java/bnymellon/codekatas/coffeekata/food/Bagel.java
Show resolved
Hide resolved
...ee-shop-kata/old-java-features/src/main/java/bnymellon/codekatas/coffeekata/food/Cookie.java
Show resolved
Hide resolved
coffee-shop-kata/old-java-features/src/main/java/bnymellon/codekatas/coffeekata/food/Donut.java
Show resolved
Hide resolved
aqsa505
force-pushed
the
master
branch
8 times, most recently
from
0ab320e
to
4953e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aqsa Malik [email protected]