Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "no module named 'abba_private'" #15

Closed
wants to merge 1 commit into from
Closed

Fix "no module named 'abba_private'" #15

wants to merge 1 commit into from

Conversation

GuillaumeLeGoc
Copy link
Contributor

Fix #14 (comment)

Still not sure why it didn't work before but at least we'll have a working version for now.

@NicoKiaru NicoKiaru added the help wanted Extra attention is needed label May 7, 2024
@NicoKiaru
Copy link
Member

I'm not sure about the proper fix for that. Did you install the abba-python package or do you work from an IDE ?

Any module / packaging person with a python knowledge is welcomed to help!

@GuillaumeLeGoc
Copy link
Contributor Author

I installed abba-python with pip install abba-python.
Before the last update (a little while ago), I could launch the GUI with a Brainglobe atlas.
I tried again today to launch the GUI from a notebook with a Brainglobe atlas and got the error. I tried again from a regular python console and I got the same error. So I went into the abba.py file at the designated line, and noticed that here :

abba_python/src/abba_python/abba.py

Line 101 in be17a50

from abba_python.abba_private.abba_atlas import AbbaAtlas # but wth ????

you import abba_private differently, so I tried to replace the import at the faulty line

abba_python/src/abba_python/abba.py

Line 181 in be17a50

from abba_private import abba_atlas
and it worked.

But wth indeed 😅

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/spinal-cord-atlas-appears-squashed-in-abba-python/96242/1

@GuillaumeLeGoc GuillaumeLeGoc closed this by deleting the head repository Jun 12, 2024
@NicoKiaru
Copy link
Member

Don't you think it was the correct fix ? Sorry I did not have time to check it yet

@GuillaumeLeGoc
Copy link
Contributor Author

Oops. I didn't know PRs were directly linked to the fork. I deleted the latter to re-fork it and start what I did from scratch... I'll try to redo the PR and find a way to work on another version (I guess this is the purpose of branches, I need to find out about that) 😓

@GuillaumeLeGoc GuillaumeLeGoc mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebooks currently non functional
3 participants
@GuillaumeLeGoc @NicoKiaru @imagesc-bot