Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adressing error logs #506

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Adressing error logs #506

merged 5 commits into from
Sep 19, 2024

Conversation

Andrei-Predoiu
Copy link
Contributor

@Andrei-Predoiu Andrei-Predoiu commented Sep 16, 2024 •
edited
Loading

  • Fixed: "no commit with sha", now we check for ref to make sure it's a valid SHA
    POST https://api.github.com/repos/BESTSELLER/bestone-bi4-log-transfer-order-core/check-runs: 422 No commit found for SHA: a560441e079d91c4afb9b39810aaa826e6155dc2 []
  • Fixed: dependabot-circleci trying to run on orgs it has been uninstalled from
  • Enhancement: If dependabot-circleci is uninstalled from an org then the repos are cleaned from the database on next run.
  • Enhancement: Improved logging by lowering loglevel from error to warn in case we cannot determine newest orb version. All instances of this have been due to rate limit
  • Enhancement: Improved logging by differentiating between other errors and file not found

@Andrei-Predoiu Andrei-Predoiu requested a review from a team as a code owner September 16, 2024 16:46
@Andrei-Predoiu Andrei-Predoiu added enhancement New feature or request minor drafts the next minor release bug-fix If this resolves a bug, put it on. labels Sep 17, 2024
@Andrei-Predoiu Andrei-Predoiu changed the title some fixes Adressing error logs Sep 18, 2024
Gaardsholt
Gaardsholt reviewed Sep 18, 2024
View reviewed changes
api/controller.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Andrei-Predoiu Andrei-Predoiu merged commit 439865b into master Sep 19, 2024
12 checks passed
@Andrei-Predoiu Andrei-Predoiu deleted the ES-3396 branch September 19, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaardsholt Gaardsholt Gaardsholt approved these changes

Assignees
No one assigned
Labels
bug-fix If this resolves a bug, put it on. enhancement New feature or request minor drafts the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrei-Predoiu @Gaardsholt