Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natural colmated cork stopper #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

GuidaRamos
Copy link
Contributor

No description provided.

@GuidaRamos GuidaRamos closed this Jul 3, 2019
@GuidaRamos GuidaRamos reopened this Jul 3, 2019
Copy link
Member

@ttasovac ttasovac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, cork lady 😄 I have some suggestions for improvement...

</teiHeader>
<text>
<body>
<entry xml:id="cork.terminology" xml:lang="pt">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably want to include the lemma in the xml:id so that you can distinguish this id from all the other entry ids. i.e. something like "cork.terminology.cork_colmated_natural_cork_stopper"

commonly receive the designatikon of colamted cork stoppers).</note></def>
</sense>
<bibl xml:lang="en">International Guide for buying cork stoppers for still wines</bibl>
<xr type="synonymy" xml:lang="pt"></xr><form><orth>rolha de cortiça colmatada</orth></form>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're pretending this is a semasiological dictionary, I would say that this is probably a translation equivalent rather than a cross-reference.

<def>
<bibl type="standard">ISO FDIS 633</bibl> <pc>-</pc> cork stopper made
from natural corkwood <pc>.</pc>
<note> NOTE: Natural cork stoppers having been colmated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably keep the note outside of def because I don't think the note is part of the definition itself

disks with a mixture of glue and cork powder coming from finishing cork stopers)
commonly receive the designatikon of colamted cork stoppers).</note></def>
</sense>
<bibl xml:lang="en">International Guide for buying cork stoppers for still wines</bibl>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this <bibl> reference for — the note? or the entry as a whole?

</teiHeader>
<text>
<body>
<entry xml:id="cork.terminology" xml:lang="pt">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the xml:lang should probably be "en" because your "lemma" is an English word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants