Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump modernizer-maven-plugin.version from 2.9.0 to 3.1.0 #2358

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps modernizer-maven-plugin.version from 2.9.0 to 3.1.0.
Updates org.gaul:modernizer-maven-annotations from 2.9.0 to 3.1.0

Release notes

Sourced from org.gaul:modernizer-maven-annotations's releases.

Modernizer Maven Plugin 3.1.0

  • Allow SuppressModernizer on local types, #155
  • Fix recommendation for Files.newOutputStream, #309
  • Fix suggestions for newXWithExpectedSize, #315

Thanks @​Bananeweizen and @​snago for sending pull requests to improve Modernizer!

Modernizer Maven Plugin 3.0.0

  • Add File violations, #301
  • Add violation for ByteStreams.toByteArray
  • Add violation for StringReader, #291
  • Add violations for Maps and Sets with expected size, #258
  • Rework pom.xml structure, #263, #264
  • Upgrade to asm 9.7.1 for Java 24 compatibility, #286

Thanks @​cstamas and @​mkarg for sending pull requests to improve Modernizer!

Commits
  • 46b5f90 modernizer-maven-plugin 3.1.0 release
  • 7a52ccc Allow SuppressModernizer on local types
  • 4db7975 Fix suggestions for newXWithExpectedSize
  • e4e0e7a Use try-with-resources where possible
  • e4852a2 Upgrade to modernizer-maven-plugin 3.0.0
  • 2d05fb9 Replace File with Path
  • d42de08 Fix recommendation for Files.newOutputStream()
  • aa3cf2b Bump org.apache.maven.plugins:maven-checkstyle-plugin
  • e30e60f Bump org.apache.maven.plugins:maven-site-plugin from 3.20.0 to 3.21.0
  • 3725c02 Bump commons-io:commons-io from 2.16.1 to 2.18.0
  • Additional commits viewable in compare view

Updates org.gaul:modernizer-maven-plugin from 2.9.0 to 3.1.0

Release notes

Sourced from org.gaul:modernizer-maven-plugin's releases.

Modernizer Maven Plugin 3.1.0

  • Allow SuppressModernizer on local types, #155
  • Fix recommendation for Files.newOutputStream, #309
  • Fix suggestions for newXWithExpectedSize, #315

Thanks @​Bananeweizen and @​snago for sending pull requests to improve Modernizer!

Modernizer Maven Plugin 3.0.0

  • Add File violations, #301
  • Add violation for ByteStreams.toByteArray
  • Add violation for StringReader, #291
  • Add violations for Maps and Sets with expected size, #258
  • Rework pom.xml structure, #263, #264
  • Upgrade to asm 9.7.1 for Java 24 compatibility, #286

Thanks @​cstamas and @​mkarg for sending pull requests to improve Modernizer!

Commits
  • 46b5f90 modernizer-maven-plugin 3.1.0 release
  • 7a52ccc Allow SuppressModernizer on local types
  • 4db7975 Fix suggestions for newXWithExpectedSize
  • e4e0e7a Use try-with-resources where possible
  • e4852a2 Upgrade to modernizer-maven-plugin 3.0.0
  • 2d05fb9 Replace File with Path
  • d42de08 Fix recommendation for Files.newOutputStream()
  • aa3cf2b Bump org.apache.maven.plugins:maven-checkstyle-plugin
  • e30e60f Bump org.apache.maven.plugins:maven-site-plugin from 3.20.0 to 3.21.0
  • 3725c02 Bump commons-io:commons-io from 2.16.1 to 2.18.0
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added bouw- en testinfrastuctuur oa. aanpassingen vanwege build servers en maven plugins dependency update (deels) automatische updates van gebruikte libraries labels Jan 20, 2025
@dependabot dependabot bot requested a review from mprins January 20, 2025 05:03
@mprins mprins removed their assignment Jan 20, 2025
@mprins mprins removed the dependency update (deels) automatische updates van gebruikte libraries label Jan 20, 2025
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs work:

  • Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.1.0:modernizer (modernizer) on project brmo-taglib: Found 9 violations -> [Help 1]
  • Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.1.0:modernizer (modernizer) on project bgt-loader: Found 3 violations -> [Help 1]
  • Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.1.0:modernizer (modernizer) on project brmo-loader: Found 12 violations -> [Help 1]
  • Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.1.0:modernizer (modernizer) on project brmo-proxyservice: Found 1 violations -> [Help 1]
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/TailTag.java:61: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/TailTag.java:65: Prefer java.nio.file.Paths.get(String, String...)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/TailTag.java:67: Prefer java.nio.file.Files.newInputStream(java.nio.file.Path)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/DownloadTag.java:46: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/DownloadTag.java:50: Prefer java.nio.file.Paths.get(String, String...)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/DownloadTag.java:104: Prefer java.nio.file.Files.newInputStream(java.nio.file.Path)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/LogfileUtil.java:59: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/LogfileUtil.java:72: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-taglib/src/main/java/nl/b3p/web/jsp/LogfileUtil.java:79: Prefer java.nio.file.Path.of(String, String...)
Error:  /home/runner/work/brmo/brmo/bgt-loader/src/main/java/nl/b3p/brmo/bgt/loader/cli/BGTLoaderMain.java:156: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/bgt-loader/src/main/java/nl/b3p/brmo/bgt/loader/cli/BGTLoaderMain.java:158: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/bgt-loader/src/main/java/nl/b3p/brmo/bgt/loader/cli/BGTLoaderMain.java:399: Prefer java.nio.file.Files.newInputStream(java.nio.file.Path)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:370: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:374: Prefer java.nio.file.Files.newInputStream(java.nio.file.Path)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:408: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:413: Prefer java.nio.file.Files.newInputStream(java.nio.file.Paths.get(String))
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:699: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:700: Prefer java.nio.file.Files.newInputStream(java.nio.file.Path)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/BrmoFramework.java:700: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/util/TopNLRsgbTransformer.java:[54](https://github.com/B3Partners/brmo/actions/runs/12861351640/job/35854614664?pr=2358#step:7:55): Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/checks/AfgifteChecker.java:42: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/checks/AfgifteChecker.java:42: Prefer java.nio.file.Files.newInputStream(java.nio.file.Path)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/checks/AfgifteChecker.java:98: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-loader/src/main/java/nl/b3p/brmo/loader/xml/TopNLFileReader.java:45: Prefer java.nio.file.Paths.get(String)
Error:  /home/runner/work/brmo/brmo/brmo-proxyservice/src/main/java/nl/b3p/brmo/service/proxy/BerichtEndpointFileServlet.java:51: Prefer java.nio.file.Paths.get(String)
Error:  Failed to execute goal org.gaul:modernizer-maven-plugin:3.1.0:modernizer (modernizer) on project brmo-taglib: Found 9 violations -> [Help 1]

Bumps `modernizer-maven-plugin.version` from 2.9.0 to 3.1.0.

Updates `org.gaul:modernizer-maven-annotations` from 2.9.0 to 3.1.0
- [Release notes](https://github.com/gaul/modernizer-maven-plugin/releases)
- [Commits](gaul/modernizer-maven-plugin@modernizer-maven-plugin-2.9.0...modernizer-maven-plugin-3.1.0)

Updates `org.gaul:modernizer-maven-plugin` from 2.9.0 to 3.1.0
- [Release notes](https://github.com/gaul/modernizer-maven-plugin/releases)
- [Commits](gaul/modernizer-maven-plugin@modernizer-maven-plugin-2.9.0...modernizer-maven-plugin-3.1.0)

---
updated-dependencies:
- dependency-name: org.gaul:modernizer-maven-annotations
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: org.gaul:modernizer-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@mprins mprins force-pushed the dependabot/maven/master/modernizer-maven-plugin.version-3.1.0 branch from 3a0b687 to 22cd3e4 Compare January 20, 2025 08:18
@mprins mprins force-pushed the dependabot/maven/master/modernizer-maven-plugin.version-3.1.0 branch from 19f5217 to f3f7bb9 Compare January 20, 2025 09:48
@mprins mprins enabled auto-merge (squash) January 20, 2025 11:56
@mprins mprins force-pushed the dependabot/maven/master/modernizer-maven-plugin.version-3.1.0 branch from ab8a0a6 to 1def1e2 Compare January 20, 2025 14:27
…rkomen

java.lang.ClassCastException: class sun.nio.ch.ChannelInputStream cannot be cast to class java.io.FileInputStream (sun.nio.ch.ChannelInputStream and java.io.FileInputStream are in module java.base of loader 'bootstrap')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bouw- en testinfrastuctuur oa. aanpassingen vanwege build servers en maven plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant