Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #56

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Test #56

wants to merge 21 commits into from

Conversation

julie-ng
Copy link
Collaborator

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
…
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@julie-ng
chore: bump all provider versions, major versions 😬
b6a08e4
@julie-ng
provider(storage): remove deprecated property
76c9455
@julie-ng
provider(aad): since v2 azure creates service principal passwords
f9573e6
@julie-ng
chore: remove unused code
d606615
@julie-ng
main-proj: specify dependency relationship
4fc3809
@julie-ng
feat(initial-setup): bootstrap aad owners group, sp with terraform
b36c3b1
@julie-ng
style(comments)): prefer '===' to separate sections
fb11def
@julie-ng
module(service-principal): rename owners to owners_list to indicate type
48ae651
@julie-ng
style: comments headings use '==='
82938d8
@julie-ng
chore(comments): rename RGs to ARM resources
9b289ff
@julie-ng
feat(environments): can specify dev or prod vars
dd08602
@julie-ng
chore(_override): improve doc
62b7d64
@julie-ng
feat: diff vars per env
74c0691
@julie-ng
ci-cd-bootstrap: assign owner role to GROUP not sp
fa871b5
@julie-ng
backend-sample: improve comment
b4041a6
@julie-ng
ci-cd-setup: add missing app role assignments, warning in readme
0cc400d
@julie-ng
providers: update aad provider
2c8778a
@julie-ng
fix: missing dependency
6b8fa50
@julie-ng
style: space
11c7f8d
@julie-ng
module(sp): remove no longer needed variable
12dd35e
@julie-ng
cicd-setup: fix object id exports
197f94e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julie-ng