Prepare to move ARM types to subpackages #3892
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We think that the problem with some of the tests is this test-specific function: It needs to take a collection of packages, so that the codeGenContext has information about the imported packages too. Otherwise it can't find the arm types and fails. |
|
I also merged + pushed, we may need to re-record the golden file tests after my changes. |
theunrepentantgeek
force-pushed
the
improve/move-arm-types
branch
from
74cd5cf
to
50ab0f1
Compare
theunrepentantgeek
force-pushed
the
improve/move-arm-types
branch
from
50ab0f1
to
0c4ac0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moves ARM types to subpackages, subject to a deny list that maintains the status quo.
We can remove groups from the deny list gradually, allowing a step by step migration to the new structure.
Special notes for your reviewer:
Currently, unit tests fail in the
internal/codegen/pipelinefolder and I haven't been able to work out why.Adding an entry to the deny list for the group
personmakes the problem go away, so it's definitely due to these changes.How does this PR make you feel:
