Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] fix: Inject Index properties to fix index resolution. #35654

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ML] fix: Inject Index properties to fix index resolution. #35654

wants to merge 3 commits into from

Conversation

kdestin
Copy link
Member

@kdestin kdestin commented May 16, 2024

Description

This pull request adds a client side fix for an issue that prevents the data service from resolving the location to MLIndex files

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@kdestin kdestin force-pushed the index-create-or-update-mlindex-props branch from ae8c939 to bac8d85 Compare May 17, 2024 19:51
@kdestin
fix,docs: Correct the return type of build_index
b10044e 
         build_index function never returns an Index object
@kdestin kdestin force-pushed the index-create-or-update-mlindex-props branch 2 times, most recently from 31329da to 66529a4 Compare May 17, 2024 21:08
@kdestin kdestin force-pushed the index-create-or-update-mlindex-props branch from 66529a4 to 0984b85 Compare May 22, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

@diondrapeck diondrapeck Awaiting requested review from diondrapeck diondrapeck is a code owner

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@MilesHolland MilesHolland Awaiting requested review from MilesHolland MilesHolland is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@ninghu ninghu Awaiting requested review from ninghu ninghu is a code owner

@YusakuNo1 YusakuNo1 Awaiting requested review from YusakuNo1 YusakuNo1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdestin @azure-sdk