[Tables] Fix and enable Batch browser tests #13955
Conversation
ghost
added
the
| @@ -9,117 +9,113 @@ import { isNode } from "../testUtils"; | |||
| import { Uuid } from "../../src/utils/uuid"; | |||
| import * as sinon from "sinon"; | |||
|
|
|||
| if (isNode || isLiveMode()) { | |||
There was a problem hiding this comment.
This is the only line removed in this file. The rest is formatting from the prettier commit hook
| const baseHeaders = getBaseBatchHeaders(batchGuid); | ||
| return { | ||
| ...baseHeaders, | ||
| // The below headers are not supported in the browser as they are flagged as "unsafe headers" |
There was a problem hiding this comment.
TIL about these unsafe headers!
| * @internal | ||
| * Builds an object with the required headers for a Batch request. For the Browser | ||
| */ | ||
| export const getBatchHeaders = getBaseBatchHeaders; |
There was a problem hiding this comment.
I wonder if it would be easier to write a function that filters out "unsafe" headers and apply that here, rather than relying on folks knowing to only add them to the node version?
Reading more specs, it looks that adding/setting/deleting/ forbidden headers should be a no-op. So it's the |
Fixes #11603
Accept-CharsetandConnectionheaders are marked asunsafein some browsers. Fixing this issue by only adding them if running in Node