Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates after azure-security-keyvault-jca:2.10.0 released #43128

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Updates after azure-security-keyvault-jca:2.10.0 released #43128

merged 3 commits into from
Nov 29, 2024
+11 −8

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Nov 28, 2024

Description

After azure-security-keyvault-jca:2.10.0 released, merge changes to main branch

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added azure-spring All azure-spring related issues KeyVault labels Nov 28, 2024
@Netyyyy Netyyyy marked this pull request as ready for review November 28, 2024 02:10
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@Netyyyy
Copy link
Member Author

Netyyyy commented Nov 28, 2024

Hi @g2vinay @vcolin7, could one of you help approve? thanks

@Netyyyy Netyyyy enabled auto-merge (squash) November 28, 2024 03:21
rujche
rujche approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Netyyyy Netyyyy merged commit 2db513c into Azure:main Nov 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rujche rujche rujche approved these changes

@saragluna saragluna saragluna approved these changes

@g2vinay g2vinay g2vinay approved these changes

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues KeyVault
Projects
Azure SDK for Key Vault
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Netyyyy @azure-sdk @g2vinay @saragluna @rujche