Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SDK for Face API from TypeSpec and customization. #40023

Merged
merged 7 commits into from
May 15, 2024
Merged

Create SDK for Face API from TypeSpec and customization. #40023

merged 7 commits into from
May 15, 2024

Conversation

leareai
Copy link
Member

@leareai leareai commented May 3, 2024

Description

This PR contains code generated from [Migrate existing Azure AI Face service to TypeSpec azure-rest-api-specs#27576.] (Azure/azure-rest-api-specs#27576)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Thank you for your contribution @leareai! We will review the pull request and get back to you soon.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 3, 2024
@leareai leareai marked this pull request as draft May 3, 2024 17:08
@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch 2 times, most recently from 7fe7e91 to 8b687c3 Compare May 6, 2024 02:18
@leareai
Copy link
Member Author

leareai commented May 6, 2024

/azp run prepare-pipelines

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 40023 in repo Azure/azure-sdk-for-java

@weidongxu-microsoft
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

/azp run java - face - ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-ai-vision-face

@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch 4 times, most recently from a19a745 to 88ea2ed Compare May 6, 2024 20:52
@leareai leareai marked this pull request as ready for review May 6, 2024 20:56
@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch 2 times, most recently from 49843a0 to 73d4b76 Compare May 10, 2024 05:40
@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch 7 times, most recently from 41d5274 to 14c7da9 Compare May 10, 2024 10:31
CodeGen from PR 29064 in Azure/azure-rest-api-specs
09b9f8a 
Merge bf7503960c4fd0c51e5608ae1cea0c04bfbadeb1 into acea819f6b350a1e2d598d02628a1719b5f9da5d
@Han-msft Han-msft mentioned this pull request May 13, 2024
Closed
@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch from 3ee86c7 to be44cff Compare May 13, 2024 03:35
weidongxu-microsoft
weidongxu-microsoft reviewed May 13, 2024
View reviewed changes
sdk/face/azure-ai-vision-face/src/samples/resources/sample-images/Family1-Dad1.jpg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure

  1. no privacy issue for the photos
  2. none of these file is large

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. All the photos are from our official documentation. We also confirmed with the owner of the documentations that we can use it without any privacy issues.

  2. All the images are small. Most of them are less then 99K. Only four out of them are around 300-500K

@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch 2 times, most recently from 38cae3f to 24db7ba Compare May 13, 2024 04:54
@leareai
Run tsp-client update
b746a53
@leareai
Initiate project
44cb320 
1. Update pom.xml
1-1. Update dependency version
1-2. Lower Jacoco test coverage threshold
2. Add README.md
3. CHANGELOG.md
@leareai
Customize Detect and Liveness APIs
232e422
@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch from 24db7ba to e8fb5d7 Compare May 13, 2024 21:43
@leareai leareai force-pushed the lel/azure-ai-vision-face-java branch from e8fb5d7 to 12dca01 Compare May 13, 2024 22:04
@weidongxu-microsoft weidongxu-microsoft merged commit 2697a8a into Azure:main May 15, 2024
19 checks passed
@leareai leareai deleted the lel/azure-ai-vision-face-java branch May 17, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Han-msft Han-msft Han-msft left review comments

@srnagar srnagar srnagar approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@brandom-msft brandom-msft Awaiting requested review from brandom-msft

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl

@mssfang mssfang Awaiting requested review from mssfang

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leareai @weidongxu-microsoft @azure-sdk @Han-msft @srnagar