Add Bicep - function-app-windows-consumption #13797

mumian · 2024-02-23T02:21:33Z

PR Checklist

Check these items before submitting a PR...

- Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

azure-quickstarts · 2024-02-23T02:23:38Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

azure-quickstarts · 2024-02-23T13:37:36Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

azure-quickstarts · 2024-02-23T13:42:49Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

mumian · 2024-02-23T14:04:41Z

@ggailey777 - can you take a look of this PR. The package, https://zipfortesting.blob.core.windows.net/deployment/cp-lin-py.zip, doesn't exist.

ggailey777

Did you intend to remove the ARM template?

ggailey777 · 2024-02-23T18:05:48Z

quickstarts/microsoft.web/function-app-windows-consumption/README.md

@@ -19,6 +20,8 @@ languages:
 ![Best Practice Check](https://azurequickstartsservice.blob.core.windows.net/badges/quickstarts/microsoft.web/function-app-windows-consumption/BestPracticeResult.svg)
 ![Cred Scan Check](https://azurequickstartsservice.blob.core.windows.net/badges/quickstarts/microsoft.web/function-app-windows-consumption/CredScanResult.svg)

+![Bicep Version](https://azurequickstartsservice.blob.core.windows.net/badges/quickstarts/microsoft.web/function-app-windows-consumption/BicepVersion.svg)
+
 This sample Azure Resource Manager template deploys an Azure Function App on Windows Consumption plan and required resource including ZipDeploy extension to mount zip package for deployment.

 [![Deploy To Azure](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazure.svg?sanitize=true)](https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fazure-quickstart-templates%2Fmaster%2Fquickstarts%2Fmicrosoft.web%2Ffunction-app-windows-consumption%2Fazuredeploy.json)


Didn't you just delete this file?

azure-quickstarts · 2024-04-11T12:47:00Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

azure-quickstarts · 2024-04-11T12:55:49Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

…mplates into 0222-function-app-windows-consumption

azure-quickstarts · 2024-04-11T14:05:11Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

azure-quickstarts · 2024-04-11T14:24:14Z

@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

mumian · 2024-04-11T14:50:15Z

@ggailey777 - do you know anything about the following error message:

2:26:59 PM - The deployment 'mainTemplate-deployment' failed with error(s). Showing 1 out of 1 error(s).
Status Message: Package deployment failed
ARM-MSDeploy Deploy Failed: 'Microsoft.Web.Deployment.DeploymentClientServerException: An error was encountered when processing operation 'Delete File' on 'C:\home\site\wwwroot\FAILED TO INITIALIZE RUN FROM PACKAGE.txt'. ---> Microsoft.Web.Deployment.DeploymentException: The error code was 0x800703E6. ---> System.IO.IOException: Invalid access to memory location.

at Microsoft.Web.Deployment.NativeMethods.RaiseIOExceptionFromErrorCode(Win32ErrorCode errorCode, String maybeFullPath)
at Microsoft.Web.Deployment.FileEx.Delete(String path)
at Microsoft.Web.Deployment.FilePathProviderBase.Delete(Boolean whatIf)
--- End of inner exception stack trace ---
--- End of inner exception stack trace ---
at Microsoft.Web.Deployment.FilePathProviderBase.HandleKnownRetryableExceptions(DeploymentBaseContext baseContext, Int32[] errorsToIgnore, Exception e, String path, String operation)
at Microsoft.Web.Deployment.FilePathProviderBase.Delete(Boolean whatIf)
at Microsoft.Web.Deployment.DeploymentObject.DeleteOperation(DeploymentSyncContext syncContext)
at Microsoft.Web.Deployment.DeploymentObject.Delete(DeploymentSyncContext syncContext)
at Microsoft.Web.Deployment.DeploymentSyncContext.HandleDelete(DeploymentObject destObject, DeploymentObject sourceParentObject)
at Microsoft.Web.Deployment.DeploymentSyncContext.SyncDirPathChildren(DeploymentObject destRoot, DeploymentObject sourceRoot)
at Microsoft.Web.Deployment.DeploymentSyncContext.SyncChildren(DeploymentObject dest, DeploymentObject source)
at Microsoft.Web.Deployment.DeploymentSyncContext.SyncChildrenNoOrder(DeploymentObject dest, DeploymentObject source)
at Microsoft.Web.Deployment.DeploymentSyncContext.SyncChildren(DeploymentObject dest, DeploymentObject source)
at Microsoft.Web.Deployment.DeploymentSyncContext.SyncChildrenOrder(DeploymentObject dest, DeploymentObject source)
at Microsoft.Web.Deployment.DeploymentSyncContext.SyncChildren(DeploymentObject dest, DeploymentObject source)
at Microsoft.Web.Deployment.DeploymentSyncContext.ProcessSync(DeploymentObject destinationObject, DeploymentObject sourceObject)
at Microsoft.Web.Deployment.DeploymentObject.SyncToInternal(DeploymentObject destObject, DeploymentSyncOptions syncOptions, PayloadTable payloadTable, ContentRootTable contentRootTable, Nullable`1 syncPassId, String syncSessionId)
at Microsoft.Web.Deployment.DeploymentObject.SyncTo(DeploymentProviderOptions providerOptions, DeploymentBaseOptions baseOptions, DeploymentSyncOptions syncOptions)
at Microsoft.Web.Deployment.DeploymentObject.SyncTo(String provider, String path, DeploymentBaseOptions baseOptions, DeploymentSyncOptions syncOptions)
at Microsoft.Web.Deployment.DeploymentObject.SyncTo(DeploymentWellKnownProvider provider, String path, DeploymentBaseOptions baseOptions, DeploymentSyncOptions syncOptions)
at Microsoft.Web.Deployment.WebApi.AppGalleryPackage.Deploy(String deploymentSite, String siteSlotId, Boolean doNotDelete) in C:__w\1\s\src\hosting\wdeploy\Microsoft.Web.Deployment.WebApi\AppGalleryPackage.cs:line 343
at Microsoft.Web.Deployment.WebApi.DeploymentController.<DownloadAndDeployPackage>d__25.MoveNext() in C:__w\1\s\src\hosting\wdeploy\Microsoft.Web.Deployment.WebApi\Controllers\DeploymentController.cs:line 492' (Code:Failed)

microsoft-github-policy-service · 2024-04-11T14:50:21Z

@mumian the command you issued was incorrect. Please try again.

Examples are:

@ agree

and

@ agree company="your company"

mumian · 2024-04-11T15:47:49Z

@ggailey777 - can you provide some details? My knowledge of azure functions is quite limited.

ggailey777 · 2024-04-11T18:33:20Z

quickstarts/microsoft.web/function-app-windows-consumption/main.bicep

+@description('The sasToken required to access _artifactsLocation. When the template is deployed using the accompanying scripts, a sasToken will be automatically generated. Use the defaultValue if the staging location is not secured.')
+param _artifactsLocationSasToken string = ''
+
+var packageUri = uri(_artifactsLocation, 'packages/nodejs.zip${_artifactsLocationSasToken}')


@patelchandni we're having trouble deploying with the package .zip file in this repo. Is this possible, or does it have to be some public URL location? I'm not familiar with how to do this in Bicep (or ARM frankly).

ggailey777 · 2024-04-11T22:36:21Z

quickstarts/microsoft.web/function-app-windows-consumption/main.bicep

+resource msDeploy 'Microsoft.Web/sites/extensions@2023-01-01' = {
+ parent: functionApp
+ name: 'MSDeploy'
+ properties: {
+ packageUri: packageUri
+ }
+}


According to @patelchandni, it sounds like the bicep-first approach might not work here since Functions requires a zipdeploy resource, which doesn't seem to yet be supported by Bicep. The PM for Functions deployments is @im-samz.

Interesting, @ggailey777. Feel free to set time up next week to discuss this in more detail. Weird that Bicep wouldn't support the zipdeploy resource.

Add Bicep

528b81d

azure-quickstarts added the bicep warnings label Feb 23, 2024

azure-quickstarts added the readme violations README violations during PR label Feb 23, 2024

mumian changed the title ~~Add Bicep~~ Add Bicep - function-app-windows-consumption Feb 23, 2024

fix readme

ffcda8d

azure-quickstarts removed the readme violations README violations during PR label Feb 23, 2024

Use MSDeploy instead of zipdeploy

6b31c5f

azure-quickstarts removed the bicep warnings label Feb 23, 2024

ggailey777 reviewed Feb 23, 2024

View reviewed changes

update package

0063abc

update the parameter file

101837b

mumian added 2 commits April 11, 2024 10:00

Merge branch 'master' of https://github.com/azure/azure-quickstart-te…

87fec49

…mplates into 0222-function-app-windows-consumption

add outputs

8e2848e

fix listkeys typo

f0b8779

ggailey777 reviewed Apr 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bicep - function-app-windows-consumption #13797

Add Bicep - function-app-windows-consumption #13797

mumian commented Feb 23, 2024

azure-quickstarts commented Feb 23, 2024

azure-quickstarts commented Feb 23, 2024

azure-quickstarts commented Feb 23, 2024

mumian commented Feb 23, 2024

ggailey777 left a comment

ggailey777 Feb 23, 2024

azure-quickstarts commented Apr 11, 2024

azure-quickstarts commented Apr 11, 2024

azure-quickstarts commented Apr 11, 2024

azure-quickstarts commented Apr 11, 2024

mumian commented Apr 11, 2024

microsoft-github-policy-service bot commented Apr 11, 2024

mumian commented Apr 11, 2024

ggailey777 Apr 11, 2024

ggailey777 Apr 11, 2024

im-samz Apr 12, 2024

Add Bicep - function-app-windows-consumption #13797

Are you sure you want to change the base?

Add Bicep - function-app-windows-consumption #13797

Conversation

mumian commented Feb 23, 2024

PR Checklist

Changelog

azure-quickstarts commented Feb 23, 2024

azure-quickstarts commented Feb 23, 2024

azure-quickstarts commented Feb 23, 2024

mumian commented Feb 23, 2024

ggailey777 left a comment

Choose a reason for hiding this comment

ggailey777 Feb 23, 2024

Choose a reason for hiding this comment

azure-quickstarts commented Apr 11, 2024

azure-quickstarts commented Apr 11, 2024

azure-quickstarts commented Apr 11, 2024

azure-quickstarts commented Apr 11, 2024

mumian commented Apr 11, 2024

microsoft-github-policy-service bot commented Apr 11, 2024

mumian commented Apr 11, 2024

ggailey777 Apr 11, 2024

Choose a reason for hiding this comment

ggailey777 Apr 11, 2024

Choose a reason for hiding this comment

im-samz Apr 12, 2024

Choose a reason for hiding this comment